Jump to content

E5570: Thunderbolt? USB-C?


ktbos

Recommended Posts

The uncompiled text file type in MaciASL is a DSL and yes, pasting the github ASL text into a new DSL file what I had tried.  That's what gave me all the compiler directive errors.  I took it as a problem with my process/tool but maybe the issue is with the file.  Either way, I don't know that it is worth pursuing at this point.  I've made my peace with the Thunderbolt port being merely decoration on my computer. 

Link to comment
Share on other sites

Wow, then I'm doing something really dumb.  So let's start with I'm doing all this on the E5570 itself with Catalina running.  The version of MaciASL I'm running is 1.5.8.  It doesn't say the developer info in the about panel and I don't recall when/where I got it. 

 

I go to https://github.com/osy86/ThunderboltReset/blob/master/ThunderboltNative/SSDT-TbtOnPCH.asl and then click on "Raw".  I copy and paste the content of what is in the web browser to a new file in TextEdit (with format set to plain text) and then save it with the name "SSDT-TbtOnPCH.asl".  Then if I double click on the file, it opens the "Console" application.  If I try to drag the file on to the running MaciASL app icon in the dock, it refuses to do anything.  If I use File Open I can't select the asl file in the Open dialog window.  If I simply change the file extension from "asl" to "dsl", then everything works fine.  But are they really the same thing?   

 

If instead I skip the TextEdit step and just do a New file in MaciASL and paste the contents from the Raw github page into that new window, it looks like it is fine initially.  (Ditto if I rename the file to ".dsl" and double-click to open.)  But when I click to compile, I get an error on line 17 that says "#error (Preprocessor)".  I've been assuming that it should have compiled with no errors if I had the right file type in the right application.  But maybe I have done everything right to this point and the file needs tweaking before it can be used.  And if that's the case, I have no idea what tweaking to do.  There are instructions at https://github.com/osy86/ThunderboltReset/blob/master/PatchingACPI.md that don't make sense to me so I was hoping to just use the base for Alpine Ridge (which is what I thought the file I was putting into MaciASL above was for based on the comments at the top of it).  But if this preprocessor error is indicating that there is more work to go before I can compile, then I'm at the end of the line because I'm not going to be able to figure out what to do based on those instructions.  Which brings me back to what I wrote above: "I'd need more handholding than I think is worth it". 

Link to comment
Share on other sites

  • Administrators

You're extracting those raw vfiles out of a complete dev package. Download the complete package from parent level and you may compile the .asl files with the provided makefile.

 

These .asl files are plain source code. You may rename the extension to .dsl to open them in MaciASL app. MaciASL uses .dsl extension for source code and .aml extension for compiled code. Here, the .asl files are meant to be compiled with the command line (Intel)  iasl tool through the makefile. If you open up the makefile with a text editor, you'll see how it operates.

 

As for errors, well they can depend on the ACPI version the code is based on and the ACPI version the compiler will be using. Check your MaciASL settings here. After a few years with good old DSDTEditor, I switched to rehabman's version of MaciASL several years ago and have been using that same version without problems ever since. Of course, I had to get into ACPI coding to be able to fix DSDT/SSDT when compiler returns errors...

 

https://github.com/RehabMan/Intel-iasl

https://github.com/RehabMan/OS-X-MaciASL-patchmatic

  • Like 1
Link to comment
Share on other sites

The only "release" is for the kext alone.  If I did a pull on the whole dev directory, I found the makefile, but the instructions are too light to guide me how to do the Make correctly.  That's why I was trying for just the one file.  But I see your point now - this one file isn't ready for use until after running through the Make. 

 

So that means that overall, I was using the tools correctly but not the project correctly.  Therefore I'm still at the point where there isn't enough there for me at this project.  If at some point that dev project gets a little bit further along or somebody else wants to spend the time to do that dev work, I'll be happy to get back into it. 

Link to comment
Share on other sites

  • Administrators

you can just go here https://github.com/osy86/ThunderboltReset/find/master and find the file you want then right click and save as. it should just download as the file. in this case as an .AML then just open that up in mac iasl. acidanthera has updated the app. maybe it is the one you are using https://github.com/acidanthera/MaciASL/releases

Link to comment
Share on other sites

×
×
  • Create New...