osxfr33k

@Jake Lo So the original method I am renaming to XREG has the Arg1 ECFL will this cause any issue since this will be ignored now in Native DSDT after the method is renamed to XREG. Method (_REG, 2, NotSerialized) // _REG: Region Availability { If ((Arg0 == 0x03)) { ECFL = Arg1 } } Name (WBTS, One) I see only 1 ACPI error preventing the SSDT from loading _WAK and if I comment out this portion in the SSDT then I get an _INI ACPI ERROR see below. 2021-05-02 18:05:15.118964-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2021-05-02 18:05:15.118964-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2021-05-02 18:05:15.119222-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [_WAK] 2021-05-02 18:05:15.119223-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [_WAK] 2021-05-02 18:05:15.119351-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS 2021-05-02 18:05:15.119352-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS 2021-05-02 18:05:15.120296-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/dswload-462) 2021-05-02 18:05:15.120296-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/dswload-462) 2021-05-02 18:05:15.131326-0500 0x73 Default 0x0 0 0 kernel: (AppleCredentialManager) AppleCredentialManager: init: returning, result = true, instance = <private>. 2021-05-02 18:05:15.143154-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2021-05-02 18:05:15.143155-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2021-05-02 18:05:15.143903-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) During name lookup/catalog 2021-05-02 18:05:15.143904-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) During name lookup/catalog 2021-05-02 18:05:15.144462-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psobject-310) 2021-05-02 18:05:15.144463-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psobject-310) 2021-05-02 18:05:15.155501-0500 0x73 Default 0x0 0 0 kernel: (IOTimeSyncFamily) IOTimeSyncClockManager::init created and initing 2021-05-02 18:05:15.155575-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2021-05-02 18:05:15.155576-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2021-05-02 18:05:15.156325-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (SSDT: LED) while loading table 2021-05-02 18:05:15.156326-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (SSDT: LED) while loading table 2021-05-02 18:05:15.157076-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-319) 2021-05-02 18:05:15.157077-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-319) 2021-05-02 18:05:15.167963-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2021-05-02 18:05:15.167964-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2021-05-02 18:05:15.168221-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) 1 table load failures, 17 successful 2021-05-02 18:05:15.168222-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) 1 table load failures, 17 successful 2021-05-02 18:05:15.168993-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-342) 2021-05-02 18:05:15.168994-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-342) 2021-05-02 18:05:15.182467-0500 0x7a Default 0x0 0 0 kernel: (AppleACPIPlatform) AppleACPICPU: ProcessorId=1 LocalApicId=0 Enabled 2021-05-02 18:05:15.193738-0500 0x7a Default 0x0 0 0 kernel: (AppleACPIPlatform) AppleACPICPU: ProcessorId=2 LocalApicId=2 Enabled 2021-05-02 18:05:15.204788-0500 0x7a Default 0x0 0 0 So I commented out the _WAK code to see if I can get rid of the ACPI ERROR and now I get the ACPI _INI error instead: 2021-05-02 18:20:32.123513-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2021-05-02 18:20:32.123514-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2021-05-02 18:20:32.123772-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [_INI] 2021-05-02 18:20:32.123773-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [_INI] 2021-05-02 18:20:32.123901-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS 2021-05-02 18:20:32.123902-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS 2021-05-02 18:20:32.124846-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/dswload-462) 2021-05-02 18:20:32.124847-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/dswload-462) 2021-05-02 18:20:32.135880-0500 0x73 Default 0x0 0 0 kernel: (AppleCredentialManager) AppleCredentialManager: init: returning, result = true, instance = <private>. 2021-05-02 18:20:32.147806-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2021-05-02 18:20:32.147807-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2021-05-02 18:20:32.148556-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) During name lookup/catalog 2021-05-02 18:20:32.148557-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) During name lookup/catalog 2021-05-02 18:20:32.149115-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psobject-310) 2021-05-02 18:20:32.149116-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psobject-310) 2021-05-02 18:20:32.160061-0500 0x73 Default 0x0 0 0 kernel: (IOTimeSyncFamily) IOTimeSyncClockManager::init created and initing 2021-05-02 18:20:32.160134-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2021-05-02 18:20:32.160135-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2021-05-02 18:20:32.160885-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (SSDT: LED) while loading table 2021-05-02 18:20:32.160886-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (SSDT: LED) while loading table 2021-05-02 18:20:32.161636-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-319) 2021-05-02 18:20:32.161637-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-319) 2021-05-02 18:20:32.172528-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2021-05-02 18:20:32.172529-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2021-05-02 18:20:32.172787-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) 1 table load failures, 17 successful 2021-05-02 18:20:32.172787-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) 1 table load failures, 17 successful 2021-05-02 18:20:32.173558-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-342) 2021-05-02 18:20:32.173559-0500 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-342)

@Jake Lo I accidentally renamed the wrong method to XINI, now I know what you meant by I might need the INI method that was in the code section below must have had a brain fart. SO I have renamed this now, still no LED yet would like to see if we can try a few more things if possible? Method (XINI, 0, NotSerialized) { OSYS = 0x07DC If (CondRefOf (\XOSI, Local0)) { If (XOSI ("Linux")) { OSYS = 0x03E8 }

I actually have it working with EmlyDinesh Custom LED patch for DSDT it works in BigSur. Just want to port it over to SSDT. See first post the patches are there. 2nd or 3rd post has native and patched DSDT.

Just tried now didn't work off to work in a bit. I noticed XWAK is being used in a couple of places already should I use something else instead of X? Here are the areas in the DSDT where _Wak and XWAK is being used before I apply the patch so XWAK is being used in other areas. Edited: I used ZWAK for the first method below not sure why those others are named XWAK before the patching? Is this the one I need to rename? Still no WIFI Led thanks for helping me I know this one is tricky. After boot only this one is renamed to ZWAK "Method (ZWAK, 1, Serialized)" Method (_WAK, 1, Serialized) // _WAK: Wake { If ((ICNF & 0x10)) { If ((\_SB.PCI0.GFX0.TCHE & 0x0100)) { If ((\_SB.IAOE.ITMR == One)) { If (((\_SB.IAOE.IBT1 & One) && (\_SB.IAOE.WKRS & 0x02))) { \_SB.PCI0.GFX0.STAT = ((\_SB.PCI0.GFX0.STAT & 0xFFFFFFFFFFFFFFFC) | One) } Else { \_SB.PCI0.GFX0.STAT = (\_SB.PCI0.GFX0.STAT & 0xFFFFFFFFFFFFFFFC) } } ElseIf (((\_SB.IAOE.IBT1 & One) && (\_SB.IAOE.WKRS & 0x02))) { \_SB.PCI0.GFX0.STAT = ((\_SB.PCI0.GFX0.STAT & 0xFFFFFFFFFFFFFFFC) | One) } Else { \_SB.PCI0.GFX0.STAT = (\_SB.PCI0.GFX0.STAT & 0xFFFFFFFFFFFFFFFC) } } If (CondRefOf (\_SB.IAOE.PTSL)) { \_SB.IAOE.PTSL = Zero } If ((\_SB.IAOE.ITMR == Zero)){} If (CondRefOf (\_SB.IAOE.ECTM)) { \_SB.IAOE.ECTM = Zero } If (CondRefOf (\_SB.IAOE.RCTM)) { \_SB.IAOE.RCTM = Zero } } WAK (Arg0) ADBG ("_WAK") If (((Arg0 == 0x03) || (Arg0 == 0x04))) { If ((GBSX & 0x40)) { \_SB.PCI0.GFX0.IUEH (0x06) } If ((GBSX & 0x80)) { \_SB.PCI0.GFX0.IUEH (0x07) } } If (((Arg0 == 0x03) || (Arg0 == 0x04))) { \_SB.PCI0.XHC.XWAK () } Return (Package (0x02) { Zero, Zero }) } Method (XWAK, 0, Serialized) { If (((XUSB == One) || (XRST == One))) { XSEL () } } Method (XWAK, 0, Serialized) { If (((XUSB == One) || (XRST == One))) { XSEL () } }

Here is the SSDT BAT Patch and Config.plist look in ACPI Patch section for the renaming of Methods, battery working great and no ACPI errors. Emly's Bat patch was actually patching SystemIO Bit Fields never figured out why but I did not patch SystemIO only EmbeddedControl fields Config.plist.zip SSDT-BAT.aml.zip

I see your point on that I added it have a look had to fulfill more Externals checked DSDT if they are IntObj, FieldUnitObj, MethodObj and DeviceObj I think I have them correct and the SSDT Scope's follows along with what is in the DSDT and for the Scope _SB, I added for the Patch Method "Method (WFBT, 0, NotSerialized)" that seem to be where the patch was in DSDT. Does Scope (_SB.PCI0) seem correct for Method XOSI, I believe this was the Scope in DSDT if it's wrong what would most likely be broken for XOSI? LED still not on after boot. Edited: Screwed up can't change _INI to XINI there were too many methods with _INI have to fix that, I have to add 1C, find 1C 5F 49 4E 49 00 replace 1C 58 49 4E 49 00. Funny when searched in Hex-Friend only found "5F 49 4E 49 00" once weird. Edited add the 1C to make it unique checked DSDT its all good now but still no LED. Method (XINI, 0, NotSerialized) { If ((MSOS <= OSME)) { ECFL = One } KINI } Method (XREG, 2, NotSerialized) { If ((Arg0 == 0x03)) { ECFL = Arg1 } } } } See attached. SSDT-XOSI-WFBT3.aml.zip

I did the modifications I spoke about above and I should at least have the WFBT LED Lit on boot maybe my Scope/Externals are off can you have a look? I will tackle the LED Wake from Sleep later. Decompiled DSDT with command "./iasl-stable -l DSDT.aml" to get hex code find _REG and replace to XREG verified with hex-friend _REG 5F 52 45 47 02 is unique as well as XREG 58 52 45 47 02. Added rename patch to Config.plist. Boot and checked System DSDT, _REG is renamed to XREG and inserted this method into SSDT. Can you have a look at my modified SSDT I had to place the code for XOSI into a scope since WFBT() is inserted there with the patch when I compile there is a compile error that WFBT (). Used MacIASL in terminal ./iasl-stable -l DSDT.aml 93BD: 70 01 45 43 46 4C 4B 49 4E 49 // p.ECFLKINI Method (_REG, 2, NotSerialized) // _REG: Region Availability { 93C7: 14 12 5F 52 45 47 02 // .._REG. Edited: Modified SSDT placed the Method (WFBT, 0, NotSerialized) under Scope (SB) still no WIFI LED at boot. SSDT-XOSI-WFBT.aml.zip SSDT-XOSI-WFBT2.aml.zip

@Jake Lo Hi Jake Lo I was successful creating the SSDT Battery Patch all that is left now is this "WiFi BT Boot/Sleep Status patch". I tried to insert the patch into the SSDT-XOSI.aml hoping it would work that way but it didn't unless I have done it wrong? WFBT is also inserted in " Method (_WAK, 1, Serialized)". Would I need to insert this entire code into its own SSDT and rename _WAK to SWAK for example or is there an easier way? WFBT () gets inserted in two places in the DSDT code below. The "Method (WFBT, 0, NotSerialized)" is easy since this is a new method this should be easy to have in its own SSDT but adding the WFBT () method in _Wak and " Method (_INI, 0, NotSerialized)' at the end of OSYS is a challenge to say the least. Besides the code below please find the TXT patch and my SSDT-XOSI-WFBT.aml modified with the patch except where the code is inserted in _wak method so I did not include it in the XOSI SSDT, trying to figure out how I can do that part to work in an all in one SSDT? I missed something there is also a WBTS Object added with the patch. I added the code at the end below to have a look at. This really looks a bit more complicated must be a better way to patch on the fly with SSDT? There are the native methods in the DSTD OWLD and OBTD to complicate this even more. I don't know if I have the Scope correct or the code the way I tried to write it. The way to patch is suppose to work is on Boot the Led is lit and on Wake from Sleep the Led will be lit again. I don't know what is more complicated the Battery patch or this one now? Its starting to look like how the SSDT Bat patch similar editing will need the two methods, mentioned already inserted into the SSDT and renamed in DSDT the _Wak method and the new one I inserted below the _Reg and figure and the WFBT in _OSI once I do that it should work or not? Have to try it is all I can do. I know the Scopes and Externals are tricky for me. The other dilemma is placing WFBT () in XOSI is out of Scope, not sure what the work around is for that? Sections in patched DSDT: Method (_WAK, 1, Serialized) // _WAK: Wake { If ((ICNF & 0x10)) { If ((\_SB.PCI0.GFX0.TCHE & 0x0100)) { If ((\_SB.IAOE.ITMR == One)) { If (((\_SB.IAOE.IBT1 & One) && (\_SB.IAOE.WKRS & 0x02))) { \_SB.PCI0.GFX0.STAT = ((\_SB.PCI0.GFX0.STAT & 0xFFFFFFFFFFFFFFFC) | One) } Else { \_SB.PCI0.GFX0.STAT &= 0xFFFFFFFFFFFFFFFC } } ElseIf (((\_SB.IAOE.IBT1 & One) && (\_SB.IAOE.WKRS & 0x02))) { \_SB.PCI0.GFX0.STAT = ((\_SB.PCI0.GFX0.STAT & 0xFFFFFFFFFFFFFFFC) | One) } Else { \_SB.PCI0.GFX0.STAT &= 0xFFFFFFFFFFFFFFFC } } If (CondRefOf (\_SB.IAOE.PTSL)) { \_SB.IAOE.PTSL = Zero } If ((\_SB.IAOE.ITMR == Zero)){} If (CondRefOf (\_SB.IAOE.ECTM)) { \_SB.IAOE.ECTM = Zero } If (CondRefOf (\_SB.IAOE.RCTM)) { \_SB.IAOE.RCTM = Zero } } WFBT () WAK (Arg0) ADBG ("_WAK") If (((Arg0 == 0x03) || (Arg0 == 0x04))) { If ((GBSX & 0x40)) { \_SB.PCI0.GFX0.IUEH (0x06) } If ((GBSX & 0x80)) { \_SB.PCI0.GFX0.IUEH (0x07) } } If (((Arg0 == 0x03) || (Arg0 == 0x04))) { \_SB.PCI0.XHC.XWAK () } Return (Package (0x02) { Zero, Zero }) } Method (_INI, 0, NotSerialized) // _INI: Initialize { OSYS = 0x07DC If (CondRefOf (\_OSI, Local0)) { If (_OSI ("Linux")) { OSYS = 0x03E8 } If (_OSI ("Windows 2001")) { OSYS = 0x07D1 } If (_OSI ("Windows 2001 SP1")) { OSYS = 0x07D1 } If (_OSI ("Windows 2001 SP2")) { OSYS = 0x07D2 } If (_OSI ("Windows 2001.1")) { OSYS = 0x07D3 } If (_OSI ("Windows 2006")) { OSYS = 0x07D6 } If (_OSI ("Windows 2009")) { OSYS = 0x07D9 } If (_OSI ("Windows 2012")) { OSYS = 0x07DC } If (_OSI ("Windows 2013")) { OSYS = 0x07DD } } ElseIf (MCTH (_OS, "Microsoft Windows")) { OSYS = 0x07CE } ElseIf (MCTH (_OS, "Microsoft WindowsME: Millennium Edition")) { OSYS = 0x07D0 } ElseIf (MCTH (_OS, "Microsoft Windows NT")) { OSYS = 0x07D0 } Else { OSYS = 0x07D1 } WFBT () } Method (WFBT, 0, NotSerialized) { If (\_SB.PCI0.LPCB.EC0.WBTS) { OWLD (One) Sleep (0x0DAC) OBTD (One) } Else { OWLD (Zero) Sleep (0x0DAC) OBTD (Zero) } } Method (_REG, 2, NotSerialized) // _REG: Region Availability { If ((Arg0 == 0x03)) { ECFL = Arg1 } } Name (WBTS, One) } Method (OWLD, 1, Serialized) { \_SB.WRST = Arg0 Arg0 ^= One If (((\_SB.ATKD.WAPF && 0x05) == Zero)) { SGPL (0x1C, One, Arg0) } } Method (OBTD, 1, Serialized) { \_SB.BRST = Arg0 SGPL (0x39, One, Arg0) SGPL (0x0F, One, Arg0) } SSDT-XOSI-WFBT.aml.zip WiFi BT Boot:Sleep Status patch.zip

OMG Jake Lo you did it you got this working as an SSDT patch this is a huge accomplishment, huge!! How can I thanks you for this. All thats left is the Battery Patch have to read over Rehabman's Hotpatch for Battery. I understand the original DSDT patch but porting this to Opencore rename and SSDT is a huge task. Also the Wifi\BT LED Sleep/Wake Fix that patch is kinda all over the DSDT not sure how I can get that one to work. Two more patches to go and I am DSDTless!! Thanks Again!

I took out the patches from the DSDT only battery patch in DSDT. Would I still need renames? Tonight I will change DSDT to "No" and boot without it to see, if that still doesn't work I would need to know what to rename? The 16 level patch I guess is tricky it sits itself below a method in the DSDT I can share that patched DSDT tonight so you can see where the patch sits if that is helpful or not?

I was hoping it would work but it didn't. You probably needs logs I am on my way to work but for now here is the Ioreg. osxfr33k’s MacBook Pro3.ioreg.zip

AsusSMC is not working on Nvidia only but I have AppleBacklightFixup from Rehabman working flawlessly all the way from Yosemite through Big Sur 11.2.1. Was your intent to make AsusSMC work on Nvidia? Here is my latest EFI and Ioreg I cleaned up a bit. I see that I am not loading SSDT-USBX but USBX settings are in my USBports.kext. Look over my EFI and Ioreg and tell me if its better now? Can you help me make 16 level FN key SSDT patch work on Keyboard brightness instead of being in DSDT I want SSDT. I looked at your patches on github for Rog GL703ge since the DSDT are similar to G750JX I used your ACPI rename patches for _CSR HPET and TIMR and RTC. I just now realized I did have all these ACPI fixes and SSDT patches in Clover and forgot to port them over to Opencore I am sorry about that . My Clover under ACPI fixes has AddDTGP FixSBUS FixHPET addMCHC FixIPIC and addDTGP. So I had all the right things in Clover I have just forgotten to bring these over to Opencore. So now everything is complete except IPIC which seems to be named correctly according to ioreg so not sure if a fix is needed? Here is what I have so far for 16 level keyboard brightness patch. I don't think I have the Externals labelled correctly but it does compile correctly but does not work. Only when DSDT is patched it works. DefinitionBlock ("", "SSDT", 2, "hack", "16Level", 0x00000000) { External (_SB_, DeviceObj) External (ATKP, DeviceObj) External (B0FF, IntObj) External (KBLV, IntObj) External (KBPW, IntObj) External (LPCB, DeviceObj) External (SB__.PCI0.LPCB.EC0_.WRAM, MethodObj) // 2 Arguments Scope (_SB) { Name (BOFF, Zero) Method (SKBL, 1, NotSerialized) { If (((Arg0 == 0xED) | (Arg0 == 0xFD))) { If (((Arg0 == 0xED) & (BOFF == 0xEA))) { Local0 = Zero BOFF = Arg0 } ElseIf (((Arg0 == 0xFD) & (BOFF == 0xFA))) { Local0 = Zero BOFF = Arg0 } Else { Return (BOFF) /* \_SB_.BOFF */ } } ElseIf (((Arg0 == 0xEA) | (Arg0 == 0xFA))) { Local0 = KBLV /* External reference */ BOFF = Arg0 } Else { Local0 = Arg0 KBLV = Arg0 } Local1 = DerefOf (KBPW [Local0]) \SB.PCI0.LPCB.EC0.WRAM (0x044B, Local1) Return (Local0) } Name (KBPW, Buffer (0x10) { /* 0000 */ 0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77, // .."3DUfw /* 0008 */ 0x88, 0x99, 0xAA, 0xBB, 0xCC, 0xDD, 0xEE, 0xFF // ........ }) Method (GKBL, 1, NotSerialized) { If ((Arg0 == 0xFF)) { Return (BOFF) /* \_SB_.BOFF */ } Return (KBLV) /* External reference */ } } } As you can see now the controller for SBUS is working with the SSDT I added in ACPI: osxfr33k@osxfr33ks-MBP ~ % kextstat | grep -E "AppleSMBusController|AppleSMBusPCI" Executing: /usr/bin/kmutil showloaded No variant specified, falling back to release 122 1 0xffffff7fa0683000 0x7000 0x7000 com.apple.driver.AppleSMBusController (1.0.18d1) D69C0758-0371-369E-88ED-E11402B91008 <55 14 13 6 5 3> 144 0 0xffffff7fa068e000 0x1000 0x1000 com.apple.driver.AppleSMBusPCI (1.0.14d1) 08A4B6D9-54C6-3632-B72C-69FA0625A0AB <14 6 5 3> osxfr33k@osxfr33ks-MBP ~ % Edited 3/21/2021 I had the wrong Hex for _CRS, I used the one from Rog GL703ge realizing my mistake just now, so I ran iasl -l on my DSDT and now have the correct code replacing the two files below, sorry for the mistake. osxfr33k’s MacBook Pro2.ioreg.zip EFI 2.zip

It stops booting as before at "BuildActDevuceEntry exit" as in my screenshot on page 2 second or 3rd post. I agree I forgot to remove XQ0E and XQ0F but in later EFI I changed patch to no only left for convenience. I will explain why I had this because my DSDT had the patch and I wanted to disable that patch in DSDT and test the SSDT with _Q0E. I agree no need to rename to EH01/02 since this is not being used on my Laptop. Also agree the rename of GFX0 is not needed I don't remember why I did this and forgot to change to "no" I was doing some testing a while back and forgot about it. Also agreed I am loading SSDT HPET I forgot to rename HPET to like XPET and agreed I don't need to rename EC0 to EC since using SSDT again an oversight on my part sorry about that. I am trying to understand why you keep enabling this in OpenCore Config under ACPI/Delete CPU to yes, see below screenshot and explain to me please? My CPU is Haswell i7-4700, I also I noticed you don't have not enabled Plugin SSDT in this EFI? Trying to understand also when you use _DSM in SSDT you need _OSI Darwin? Also why use DTGP at the end of the all in one patch SSDT? One more thing are you saving Opencore Config in OpenCore Configurator or just viewing? It has done something again I have no GUI, I think Opencore Configurator is doing something bad if you are saving or for some reason something is happening to resources? Can you make changes with a plist editor maybe this is why it won't complete the boot? I have used Clover Configurator for years and never noted and issues doing so even though developers would always warn not to open and save with it because it can introduce changes that were not in the original confi.plist. Could something be happening with OpenCore Configurator making changes that you never you did, like the pictures below? Are you changing anything in each section with Quirks because they are different from my original have a look and compare my original Config.plist with yours look at all the quirks in each section you will see changes. My CPU CFG is unlocked but you keep changing back to Yes for AppleXcpmCfgLock or is OpenCore Configurator changing this to default?

Well all the patches I posted on my first post were weeks and weeks of hard work in 2014 by EmlyDinesh very famous developer from here and we spent weeks both him and I perfecting these patches specific to my laptop. So the AsusSMC kext is for integrated graphics and not nvidia? Can we start over with SSDT all I want to do is make 16 level FN key brightness patch for keys and lcd as SSDT. Also WiFi/BT wake sleep LED fix and battery patch all as SSDT. I have my LCD working flawless with Rehabman Apple backlight fixup which was meant for Intel GPU but I figured out on my own how to get it to work on my nvidia discreet GPU. I don’t want DSDT anymore for this laptop.

I will try in a few minutes getting ready for work and at the same time will try this. My Laptop is Asus G750JX-DB71 Haswell Processor with Intel GPU disabled by Asus and only with Nvidia Discreet Graphics GPU GTX 770m. Do you have more time over the weekend to do more testing? I am US Central time maybe our times are different?

Sorry I forgot to enable DSDT. I will do this in a few minutes and send it over. Is the 16 level patch still in this DSDT? Will we be able to create the SSDT battery patch later because this was the entire point I want to do away with DSDT and even though you can load DSDT in opencore it does not like it. I have tested and proved it causes issues with ACPI patch rename in Opencore, and possible other things as well. I read this in the Dortania OpenCore Guide. I will load it for now because without the battery patch its breaks ACPI and that can cause issues as well but eventually would you be able to help me create the SSDT battery patch? Thanks

It only boots pre kernel message [EB] messages then stops never loads the kernel. I tried as you have it now without HPET and with HPET. My CFG lock is disabled, I have unhidden Advanced menus in Bios and disabled CFG lock but changing those options in Kernel Quirks to "no" made no difference. edited: I am going to try a few different things because I noticed on the first EFI you attached I did not get the GUI boot once I replaced the resource folder with my original which is what you had anyhow, it boot back to the GUI. Maybe there is some issue with syncing files after they are zipped and attached then unzipped on my end just a theory. If you see one of my prior posts MacIASL was leaving blank lines when I was pasting code. Another thing I remember EmlyDinesh had a real hard time with some of those patches he made he told he had to make many changes many times some bug he mentioned not sure what but something in the code maybe a variable or spacing just theorizing I really have no idea. So what I can try is use my opencore core files and just make all the changes manually in the config re-compile all the ACPI files and give it another try both the original EFI and the latest one you sent. Thanks for being patient with me. We will get this figured out I am sure of it. Edited Again: Made some changes in config more like my original, made Quirk Changes and Nvram flags removed syms flag. At this point no Brightness control, brightness maxed out and for some reason no PS2 keyboard? Find attached my Ioreg and OpenCOre config I made adjustments to. I also noticed under ACPI Delete you enabled the CPU patches not sure if this was the cause or what now I have to enable one thing back at a time you had made adjustments to my original config to see what was causing the kernel not to load. In the meantime over the weekend if you want to test a little more frequently I can if you will be able to? Sorry one more thing I tried the all in one ACPI patch with my adjusted config and that issue is the same as is was before the config modification did not change the boot process, it stops as I posted above and I have the keyboard working again. Now with the current EFI you provided and after adding PNLF I have brightness slider in System Preferences Display but the slider gives me just on/off slide all the way to the left black screen which is howit should work and sliding it partially or all the way does not change brightness. The 16 key press comes later I am assuming. Ioreg_Config.zip

She would not boot I have a picture not sure if that will help. Debug is on but no log in EFI to attach. This really looks great placing all patches in one SSDT thanks so much for that. Can I load my own Usbports.kext and disable usbinjextall or you need it this way for now? Let me know what you think and what should I try next. Thanks! Edited: I ran this command at the terminal may have found something: log show --predicate "processID == 0" --start 2021-03-17 --debug I don't think this is the reason why thought it might be HPET don't think its that either. Backtrace 0xffffff7fa0aa9b34 0xffffff7fa0a767bb 0xffffff7fa0a77464 0xffffff8000a4628e 0xffffff7fa0a869e2 0xffffff8000a5045b 0xffffff80003a8e51 2021-03-17 21:18:00.859159-0500 0x77e Default 0x0 0 0 kernel: Kernel Extensions in backtrace: 2021-03-17 21:18:00.859170-0500 0x77e Default 0x0 0 0 kernel: com.apple.iokit.IOGraphicsFamily(585.0)[EF8876FC-C6D6-3D53-9915-762EF4F12870]@0xffffff7fa0a62000->0xffffff7fa0a90fff 2021-03-17 21:18:00.859179-0500 0x77e Default 0x0 0 0 kernel: dependency: com.apple.iokit.IOPCIFamily(2.9)[BF2C5E86-1E8F-3FD4-9874-7738178FA73B]@0xffffff8002c1f000->0xffffff8002c46fff 2021-03-17 21:18:00.859190-0500 0x77e Default 0x0 0 0 kernel: com.apple.iokit.IONDRVSupport(585.0)[40BEBEA2-BBB5-3B09-B6AE-B4B372775FBD]@0xffffff7fa0aa7000->0xffffff7fa0aaffff 2021-03-17 21:18:00.859201-0500 0x77e Default 0x0 0 0 kernel: dependency: com.apple.iokit.IOGraphicsFamily(585)[EF8876FC-C6D6-3D53-9915-762EF4F12870]@0xffffff7fa0a62000->0xffffff7fa0a90fff 2021-03-17 21:18:00.859214-0500 0x77e Default 0x0 0 0 kernel: dependency: com.apple.iokit.IOPCIFamily(2.9)[BF2C5E86-1E8F-3FD4-9874-7738178FA73B]@0xffffff8002c1f000->0xffffff8002c46fff 2021-03-17 21:18:00.906254-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.906260-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.906264-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.906283-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.906295-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.906300-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.908834-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.908840-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.908844-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.908847-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.908850-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.908854-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]> 2021-03-17 21:18:00.908858-0500 0xc8e Default 0x0 0 0 kernel: (kernel) <compose failure [UUID]>

I will try and get this to you either before I head out to work or after by tonight. I will edit this post, and include it, also thanks for helping, its hard to find tat kind of help these days. I have attached them, using rehabmana's AppleBacklightFixup.kext but to get this to work I had to use these flags in nvram applbklbeta applbkl=0 this has basically worked for me from Mojave all the way through Big Sur. Using VoodooHDA since I have the subwoofer they were never able to get this to work with AppleHDA and with the Midi setting I can now control front and rear speakers. I also load AppleHDA to it can do its conversations like to HDEF for example. I want to be completely DSDTless, OpenCore does not do well with loading a DSDT since it already loads a DSDT in firmware. I see issues loading my own DSDT for example GFX0 rename to IGPU shows no change when my DSDT is loaded but if I remove my DSDT the rename of GFX0 to IGPU shows up in MacIASL System DSDT. I also have Clover EFI if you want to look at that as well, let me know. I am trying to figure out how I will fix Mutex in OpenCore. I have also attached all my patches as txt files if you want o have a look at them, Emly prepared for me back in 2014. EFI.zip osxfr33k’s MacBook Pro.ioreg.zip Patches.zip

@Jake Lo I am trying right now to finish the 16 level FN key into SSDT and again compile error wondering if you an have a look maybe it will compile for you or you may see a mistake? DefinitionBlock ("", "SSDT", 2, "hack", "fn 16 stage", 0x00000000) { External (_SB_.PCI0, DeviceObj) External (_SB_.PCI0.LPCB, DeviceObj) External (_SB_.PCI0.LPCB.EC0_, DeviceObj) External (_SB_.PCI0.LPCB.EC0_.SKBL, MethodObj) // 0 Arguments External (_SB_.PCI0.LPCB.EC0_.GKBL, MethodObj) // 0 Arguments External (_SB_.PCI0.LPCB.ATKP, DeviceObj) External (_SB_.PCI0.LPCB.EC0.WRAM, DeviceObj) External (B0FF, IntObj) External (KBLV, IntObj) External (KBPW, IntObj) Scope (_SB) { Name (BOFF, Zero) Method (SKBL, 1, NotSerialized) { If (((Arg0 == 0xED) | (Arg0 == 0xFD))) { If (((Arg0 == 0xED) & (BOFF == 0xEA))) { Local0 = Zero BOFF = Arg0 } ElseIf (((Arg0 == 0xFD) & (BOFF == 0xFA))) { Local0 = Zero BOFF = Arg0 } Else { Return (BOFF) /* \_SB_.ATKD.BOFF */ } ElseIf (((Arg0 == 0xEA) | (Arg0 == 0xFA))) { Local0 = KBLV /* \_SB_.KBLV */ BOFF = Arg0 } Else { Local0 = Arg0 KBLV = Arg0 } Local1 = DerefOf (KBPW [Local0]) ^^PCI0.LPCB.EC0.WRAM (0x044B, Local1) Return (Local0) } Name (KBPW, Buffer (0x10) { /* 0000 */ 0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77, // .."3DUfw /* 0008 */ 0x88, 0x99, 0xAA, 0xBB, 0xCC, 0xDD, 0xEE, 0xFF // ........ }) Method (GKBL, 1, NotSerialized) { If ((Arg0 == 0xFF)) { Return (BOFF) /* \_SB_.ATKD.BOFF */ } Return (KBLV) /* \_SB_.KBLV */ } } } @Baio77 Mine has only dedicated GTX 770M intel GPU is disabled. Will this work with this condition? I will give that a try only want to eliminate the DSDT and have the patches as SSDT, what I have left to work on the really hard one is Battery and another easy one is the WIfi/BT LEd wake thing. Where are these kexts, actually I found AsusSMC.kext from a github site and the brightnesskeys.kext by searching here was in Jake Lo's thread. Are you sure these are not for Integrated rather than discreet only graphics? Keep in mind EMlyDinesh made these custom DSDT patches a few years ago and they have worked for me from Yosemite all the way through Big Sur. I have 16 level brightness for the Keyboard Keys and 16 level Brightness for the LCD with Apple Animation. Will those kexts enable this?

That works and I see the issue look at this both in Catalina and Big Sure. Catalina using MaciASL v1.57 How in the world can something like this happen missing line numbers have a look it stops at line 22:

Thanks I just did that see below, but now I get the syntax error in a different spot where you see the arrows I drew. Does it compile for you, I am using Acidanthera MacIASL version. 1.59. DefinitionBlock ("", "SSDT", 2, "hack", "fnkey", 0x00000000) { //External (_SB_.PCI0, DeviceObj) //External (_SB_.PCI0.LPCB, DeviceObj) External (\_SB.PCI0.LPCB.EC0_, DeviceObj) //External (_SB_.PCI0.LPCB.EC0_.XQ0E, MethodObj) // 0 Arguments //External (_SB_.PCI0.LPCB.EC0_.XQ0F, MethodObj) // 0 Arguments External (\_SB.ATKD.IANE, MethodObj) External (\_SB.ATKP, IntObj) Scope (\_SB.PCI0.LPCB.EC0) { Method (_Q0E, 0, NotSerialized) // _Qxx: EC Query, xx=0x00-0xFF { If (ATKP) { \_SB.ATKD.IANE (0x20) } } >>>>> Method (_Q0F, 0, NotSerialized) // _Qxx: EC Query, xx=0x00-0xFF { If (ATKP) { \_SB.ATKD.IANE (0x10) } } } }

Does the FN key patch look correct I get a compile error syntax error, unexpected '}' expecting '{'. I have the closed bracket at the end? Does this code look correct? I have already created the rename in OpenCore ACPI /Patch/Rename patch. I think I might have some External Object naming wrong but the syntax error occurs at the first IF statement line. DefinitionBlock ("", "SSDT", 2, "hack", "fnkey", 0x00000000) { External (_SB_.PCI0, DeviceObj) External (_SB_.PCI0.LPCB, DeviceObj) External (_SB_.PCI0.LPCB.EC0_, DeviceObj) External (_SB_.PCI0.LPCB.EC0_.XQ0E, MethodObj) // 0 Arguments External (_SB_.PCI0.LPCB.EC0_.XQ0F, MethodObj) // 0 Arguments External (_SB_.ATKD, DeviceObj) External (_SB_.ATKP, IntObj) Scope (_SB.PCI0.LPCB.EC0) { Method (XQ0E, 0, NotSerialized) // _Qxx: EC Query, xx=0x00-0xFF { If (ATKP) { _SB.PCI0.LPCB.ATKD.IANE (0x20) } } Method (XQ0F, 0, NotSerialized) // _Qxx: EC Query, xx=0x00-0xFF { If (ATKP) { _SB.PCI0.LPCB.ATKD.IANE (0x10) } } } } Actually I should not rename _Q0E and _Q0F in the SSDT rather in the DSDT instead I think? I found something online that was coded this was yet I still get the syntax error unexpected '{'. I am using the latest MacIASL from Acidanthera. I commented out some of the externals they did not have in their SSDT and they used \_SB. instead of _SB_. Here was the code I found online what do you think can be wrong? DefinitionBlock ("", "SSDT", 2, "hack", "fnkey", 0x00000000) { //External (_SB_.PCI0, DeviceObj) //External (_SB_.PCI0.LPCB, DeviceObj) //External (_SB_.PCI0.LPCB.EC0_, DeviceObj) //External (_SB_.PCI0.LPCB.EC0_.XQ0E, MethodObj) // 0 Arguments //External (_SB_.PCI0.LPCB.EC0_.XQ0F, MethodObj) // 0 Arguments External (\_SB.ATKD.IANE, MethodObj) External (\_SB.ATKP, IntObj) Scope (\_SB.PCI0.LPCB.EC0) { Method (_Q0E, 0, NotSerialized) // _Qxx: EC Query, xx=0x00-0xFF { If (ATKP) { \_SB.ATKD.IANE (0x20) } } Method (_Q0F, 0, NotSerialized) // _Qxx: EC Query, xx=0x00-0xFF { If (ATKP) { \_SB.ATKD.IANE (0x10) } } } }

sorry forgot to include them yes my DSDT is patched and working. Rehabman has a thread on the SSDT battery patching its monstrous learning. here is my patched dsdt and vanilla dsdt. I am starting simple with the FN key and 16 level keyboard brightness. Need to insert external devices, methods etc and make sure I have a rename patch in Opencore for the vanilla DSDT. DSDTs.zip

Hello to all and to Emly hope to see you around again, I wanted to convert these patches meant for DSDT but port them over for OpenCore use by converting them to SSDT and I am sure conversely ACPI/Patching. Below are the 4 patches I would like to port, then I will no longer have to use DSDT. Fn Brightness Keys Patch KeyboardBacklight 16Levels Patch Battery Patch WiFi BT Boot/Sleep Status patch I have zipped them up as one attachment will this be possible to port these over to SSDT / OpenCore ACPI/Patches? Patches.zip