Help with dsdt.

[kostas54]

I need your help.

I have a dsdt with ECRW (in a _CRS method).
I followed Rehabman's guide : 

Replace:
Code:
If (LEqual (PM6H, One))
{
CreateBitField (BUF0, \_SB.PCI0._Y0C._RW, ECRW) // _RW_: Read-Write Status
Store (Zero, ECRW (If (PM0H)
{
CreateDWordField (BUF0, \_SB.PCI0._Y0D._LEN, F0LN) // _LEN: Length
Store (Zero, F0LN)
}))
}
With:
Code:
If (LEqual (PM6H, One))
{
CreateBitField (BUF0, \_SB.PCI0._Y0C._RW, ECRW) // _RW_: Read-Write Status
Store (Zero, ECRW)
}
If (PM0H)
{
CreateDWordField (BUF0, \_SB.PCI0._Y0D._LEN, F0LN) // _LEN: Length
Store (Zero, F0LN)
}

When I click compile it shows no errors. I save dsdt as aml but when I open it again shows same error.

Can someone take a look ?

Attaching dsdt file.

DSDT.aml.zip

[Jake Lo]

It's an IASL issue. You don't edit *.aml directly.

You should only work with decompile *.dsl file. Once error is fixed and able to compile without error, the you're good to go.

I have a patch for that here so you don't have to edit it manually.

[kostas54]

That's what I did.

I decompiled original dsdt.aml as dsl. Applied the patch , compile shows no error and then save as aml.

But when I open this dsdt.aml shows the same error and the patch seem not to have been applied.

[Jake Lo]

Just told you, it's an IASL bug. When you open *.aml file directly you will encounter the error due to the bug. If you re-open the  fixed *.dsl file, you won't see that error because it's fixed.

 

[kostas54]

That's what I do.

I decompile patched aml file to dsl , then I open tht dsl and the error is still there.

 

Could you do me a favour ?

Can you patch the previous attached file and sent it to me?

Maybe something wrong with my iasl confg.

[Jake Lo]

Here, error free

You are suppose to decompile it. Apply the patch I linked, that should fix it. You'll encounter new errors about exiting scopes.

Apply this patch, it basically just comment out the external declaration. Now you can apply whatever fixes or patches you want. Save this copy if you want add more patches in the future. 

Spoiler

 

#======= Remove Unnecessary External declarations found on KabyLake systems —> that causes errors
# created by Jake Lo of OSXLatitude

into definitionblock code_regex External\s+\(BNUM,\s+UnknownObj\) replace_matched
begin
// %0
end;
into definitionblock code_regex External\s+\(IDPC,\s+UnknownObj\) replace_matched
begin
// %0
end;
into definitionblock code_regex External\s+\(DLPN,\s+UnknownObj\) replace_matched
begin
// %0
end;
into definitionblock code_regex External\s+\(IDMN,\s+UnknownObj\) replace_matched
begin
// %0
end;
into definitionblock code_regex External\s+\(CBID,\s+UnknownObj\) replace_matched
begin
// %0
end;

 

 

DSDT.dsl.zip

[kostas54]

Thank you my friend. 

 

Just to be sure (sorry but my English i not too good)...

I open the dsl you sent me and it error free. 

I save it as aml.

I decompile again aml to dsl.

I open dsl and the error is still there.

Is that normal?

[Jake Lo]

I guess you could say that is normal. You'll have to apply the patch every time you do that.

That's why you only work with the fixed *.dsl file and keep a copy for later if you want to make more changes in the future.